Skip to content

Conversation

chconil
Copy link
Contributor

@chconil chconil commented Dec 19, 2024

Kernel configuration is not currently not detected, even when the creation is successful. This fixes it.
Feel free to edit the patch

@m-1-k-3 m-1-k-3 added bug Something isn't working Core modules (Sxx) The core scanning modules (Sxx modules) EMBA labels Dec 19, 2024
Copy link
Member

@m-1-k-3 m-1-k-3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What a nasty refactoring bug. Thanks for fixing it!

Copy link
Member

@m-1-k-3 m-1-k-3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks as you are using tabs instead of spaces:

image

As we are using spaces could you please change this to use two spaces for a tab?

@chconil
Copy link
Contributor Author

chconil commented Dec 19, 2024

looks as you are using tabs instead of spaces:

image

As we are using spaces could you please change this to use two spaces for a tab?

Weird, my editor should have catched that. Anyway, fixed ! :)

@chconil chconil requested a review from m-1-k-3 December 19, 2024 21:29
@m-1-k-3 m-1-k-3 merged commit d1e12e8 into e-m-b-a:master Dec 20, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Core modules (Sxx) The core scanning modules (Sxx modules) EMBA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants