Skip to content

[Bug]: Docker In Docker does not work with AMD #2849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 27, 2025
Merged

[Bug]: Docker In Docker does not work with AMD #2849

merged 1 commit into from
Jun 27, 2025

Conversation

peterschmidt85
Copy link
Contributor

Fixes #2847

@peterschmidt85 peterschmidt85 requested a review from un-def June 26, 2025 19:03
@peterschmidt85 peterschmidt85 linked an issue Jun 26, 2025 that may be closed by this pull request
[Bug]: Docker In Docker does not work with AMD #2847
Closed
@peterschmidt85 peterschmidt85 requested a review from Bihan June 26, 2025 19:03
@peterschmidt85
Copy link
Contributor Author

@Bihan You can test the fix by installing dstack CLI from this branch. No server changes are required.

@peterschmidt85
Copy link
Contributor Author

@un-def I assume Docker-In-Docker should also work on Tenstorrent, is this correct?

@un-def
Copy link
Collaborator

un-def commented Jun 27, 2025 •
edited
Loading

@peterschmidt85

I assume Docker-In-Docker should also work on Tenstorrent, is this correct?

Should work with any hardware (other than NVIDIA) that don't require a specific Docker runtime

@peterschmidt85 peterschmidt85 merged commit cb9d746 into master Jun 27, 2025
25 checks passed
@peterschmidt85 peterschmidt85 deleted the 2847-docker-in-docker-amd branch June 27, 2025 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@un-def un-def un-def approved these changes

@Bihan Bihan Bihan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Docker In Docker does not work with AMD
3 participants
@peterschmidt85 @un-def @Bihan