Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR fixes Postgres deadlocks caused by SELECT FOR UPDATE statements that can be blocked by transactions that modify child tables. The LOCKING contributing guide is updated to include this caveat:
For example, deadlocks could happen between a stop_runs transaction that takes explicit runs and then jobs FOR UPDATE locks and a job background processing transaction that updates jobs, which causes Postgres to take first jobs lock and then
FOR KEY SHARE
runs lock.Also fixed taking lock on joined runs table when processing jobs.