Skip to content

Conversation

countvajhula
Copy link
Collaborator

Summary of Changes

In the wake of the transition to using macros to define commands (to have a good abstraction of a command that eliminates ad hoc tidying etc.), many commands function differently than before. This PR fixes any issues with these commands while also improving other, longstanding UX parameters. The changes include:

  • single-step undo for many operations that formerly required two steps, including change
  • improvements in primitive lisp parsers to fine tune many little UX details
  • simplify the implementations of tidy, paste, and many other commands, including reducing dependence on Evil and other non-core packages
  • full visual characterwise motions to avoid escaping symex state in some cases where we might be tempted to
  • fixes in append-line, replace, and many other commands
  • improve the determination of symexes affected by line-oriented operations so that they can be properly indented if they are disturbed
  • handle more cases in many operations like paste, replace, and more
  • fix many edge cases in various operations
  • improve Lisp primitives in general
  • handle inline comments better in some commands
  • rename functions following the public/private naming convention properly
  • many edge cases esp. in pasting before/after with and without quantifiers
  • better newline separator necessity modeling e.g. in pasting at the toplevel
  • some docs on debugging
  • more natural UX in some operations

Public Domain Dedication

  • In contributing, I relinquish any copyright claims on my contribution and freely release it into the public domain in the simple hope that it will provide value.

(Why: The freely released, copyright-free work in this repository represents an investment in a better way of doing things called attribution-based economics. Attribution-based economics is based on the simple idea that we gain more by giving more, not by holding on to things that, truly, we could only create because we, in our turn, received from others. As it turns out, an economic system based on attribution -- where those who give more are more empowered -- is significantly more efficient than capitalism while also being stable and fair (unlike capitalism, on both counts), giving it transformative power to elevate the human condition and address the problems that face us today along with a host of others that have been intractable since the beginning. You can help make this a reality by releasing your work in the same way -- freely into the public domain in the simple hope of providing value. Learn more about attribution-based economics at drym.org, tell your friends, do your part.)

Handle additional cases of empty lists to help ensure that motion does
not attempt to enter empty expressions.
This fixes some indentation bugs in pasting multiple yanked
expressions and in pasting with a quantifier, and also simplifies the
code by sharing functionality common to pasting before and after.
Eliminate special cases by using generic region indenting. Also add
the abilty to specify a quantifier/count.
@countvajhula countvajhula marked this pull request as ready for review March 11, 2023 09:25
@countvajhula
Copy link
Collaborator Author

Lots of improvements here. Merging since these patch over the issues introduced by the other "macros" PR. Again, review appreciated if you have time - but there will be a final review on the integration branch before merging to main in any case 👍

@countvajhula countvajhula merged commit 74b6f6f into drym-org:2.0-integration Mar 11, 2023
@countvajhula countvajhula deleted the low-level-ux-improvements branch March 11, 2023 09:34
@countvajhula countvajhula mentioned this pull request Mar 11, 2023
33 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant