Adding processor breakpoint enable/disable button. #193
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! I'll check it in the next few days days and get back to you. |
|
It's fine thanks! just added proper initialization. Breakpoints in Gearboy are quite bad designed/implemented. This is old code I'm not very proud of 🤣 You can have a look at the https://github.com/drhelius/Geargrafx debugger, maybe in the future I will improve Gearboy in the same way. |
|
You can quickly disable all and get back to whatever combination of enabled or disabled breakpoints you had before. This functionality is present in Geargrafx. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by GDB's capability of disabling/enabling breakpoints, I added an enable button directly next to the delete button of a processor breakpoint. This allows to disable a breakpoint without deleting it.
Unfortunately, to keep track of deleted breakpoints I had to add a field to
struct stDisassembleRecord.If you like the idea as well, I could add the same feature for memory breakpoints .
Furthermore, one could get rid of
emu_debug_disable_breakpoints_cpuby simply disabling all breakpoints.Any feedback is welcome.