Skip to content

Excessive bounds checking when reading multi-byte values #62

@drewnoakes

Description

@drewnoakes

For example, ByteArrayReader.GetInt32 validates the index for four bytes. It then calls GetByte four times, which causes a further four validations.

One potential solution is to have a non-public GetByteInternal method that doesn't validate.

Investigate at the same time whether we can have the GetByte calls be inlined. Being virtual probably nixes that.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions