Skip to content

Update xmpcore to 6.0.6 #382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 14, 2019
Merged

Conversation

SergiusTheBest
Copy link
Contributor

This updates com.adobe.xmp:xmpcore to 6.0.6. It's required for fixing extremely slow parsing when photoshop:DocumentAncestors node reaches over 100000 items. I will send the fix in another PR.

@SergiusTheBest
Copy link
Contributor Author

Also I tried updating to 6.1.10 but it fails 2 tests so stick to 6.0.6.

@kwhopper
Copy link
Collaborator

kwhopper commented Dec 8, 2018

What tests fail on 6.1.10? We got it to work on the .NET project, but admittedly that's a bit different.

@SergiusTheBest
Copy link
Contributor Author

Here they are:

expected:<168> but was:<167>
java.lang.AssertionError
	at com.drew.metadata.xmp.XmpReaderTest.testExtract_PropertyCount(XmpReaderTest.java:67)
expected:<168> but was:<167>
java.lang.AssertionError
	at com.drew.metadata.xmp.XmpReaderTest.testGetXmpProperties(XmpReaderTest.java:75)

@SergiusTheBest
Copy link
Contributor Author

Any news?

@SergiusTheBest
Copy link
Contributor Author

Just a kindly reminder.

@drewnoakes
Copy link
Owner

@SergiusTheBest thanks for this, it looks good. Apologies for the delay.

@drewnoakes drewnoakes merged commit b0573a9 into drewnoakes:master Feb 14, 2019
@SergiusTheBest
Copy link
Contributor Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants