Fix some null pointer exceptions in MP4 code #369
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@davidekholm please also take a look at these changes. |
|
Thanks. The code seems to behave now. |
|
Any ideas when this fix is going to be released? |
|
I had the same issue. You can build the snapshot version locally and
reference that in your local build.
…On Mon, Dec 31, 2018 at 9:48 AM Mark Himsley ***@***.***> wrote:
Any ideas when this fix is going to be released?
I'm going through the hundreds of thousands of media files I have, and
it's annoying that the GoPro MP4 files are causing the throwing of this
runtime exception.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#369 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AI5Ow0nxQ12HMKG6vRieVc1E7sCVK6Itks5u-j_1gaJpZM4XbRNl>
.
|
|
@drewnoakes @payton Isn't it time for a release now anyway, or is something holding it up? |
|
I think we're in good shape for a release. I'm catching up with a tonne of stuff that piled up during the holidays, but have put this on my list. |
|
@drewnoakes still not a time for a release? that would be nice to have it soon :) . Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #368.
@payton if you're happy with these changes, please go ahead and merge the PR, or feel free to push your own changes to it. Thanks!