Skip to content

Improve Quicktime Metadata Atom handling #331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 23, 2018
Merged

Conversation

nagix
Copy link
Collaborator

@nagix nagix commented Mar 23, 2018

Problem

NullPointerException occurs on some MOV file inputs. The cause is likely to be an undefined metadata tag in the Quicktime Metadata Atom.

Solution

  • Add null check for tag ID lookup
  • Add com.apple.quicktime.pixeldensity tag
  • The current implementation interprets a value as a string using the default encoding, but it can be other data types such as integer, array, etc. So, add the code to read the data type field and set it (Reference)
  • Add tag constants for QuickTimeMetadataDirectory
  • Add tag descriptions for some tags

@drewnoakes
Copy link
Owner

👍 Looks good to me.

@payton is more familiar with the code so I'll let him review/merge.

@payton
Copy link
Collaborator

payton commented Mar 23, 2018

Looks good!

@payton payton merged commit 2c80f00 into drewnoakes:master Mar 23, 2018
@nagix nagix deleted the issue-331 branch March 24, 2018 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants