Skip to content

nydus-image: fix a underflow issue in get_compressed_size() #1130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 3, 2023
Merged

nydus-image: fix a underflow issue in get_compressed_size() #1130

merged 1 commit into from
Mar 3, 2023

Conversation

jiangliu
Copy link
Collaborator

@jiangliu jiangliu commented Mar 3, 2023

Fix a underflow issue in get_compressed_size() by skipping generating useless Tar/Toc headers.

@jiangliu jiangliu requested a review from a team as a code owner March 3, 2023 01:46
@jiangliu jiangliu requested review from bergwolf, changweige and hsiangkao and removed request for a team March 3, 2023 01:46
@anolis-bot
Copy link
Collaborator

@jiangliu , a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/54258

@jiangliu
nydus-image: fix a underflow issue in get_compressed_size()
8a4bc8b 
Fix a underflow issue in get_compressed_size() by skipping generating
useless Tar/Toc headers.

Fixes: dragonflyoss#1129

Signed-off-by: Jiang Liu <gerry@linux.alibaba.com>
@jiangliu jiangliu force-pushed the fix-get-compressed-size branch from b6d01a8 to 8a4bc8b Compare March 3, 2023 01:57
@anolis-bot
Copy link
Collaborator

@jiangliu , the code has been updated, so a new test job has been submitted. Please wait in patience. The test job url: https://tone.openanolis.cn/ws/nrh4nnio/test_result/54264

@anolis-bot
Copy link
Collaborator

@jiangliu , The CI test is completed, please check result:

Test CaseTest Result
build rust golang image✅ SUCCESS
compile nydusd✅ SUCCESS
compile ctr remote✅ SUCCESS
compile nydus snapshotter✅ SUCCESS
run container with rafs✅ SUCCESS
run container with zran✅ SUCCESS
run container with rafs and compile linux✅ SUCCESS

Congratulations, your test job passed!

@imeoer imeoer merged commit bca1b8a into dragonflyoss:master Mar 3, 2023
@anolis-bot
Copy link
Collaborator

@jiangliu , The CI test is completed, please check result:

Test CaseTest Result
build rust golang image✅ SUCCESS
compile nydusd✅ SUCCESS
compile ctr remote✅ SUCCESS
compile nydus snapshotter✅ SUCCESS
run container with rafs✅ SUCCESS
run container with zran✅ SUCCESS
run container with rafs and compile linux✅ SUCCESS

Congratulations, your test job passed!

@jiangliu jiangliu deleted the fix-get-compressed-size branch March 28, 2023 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imeoer imeoer imeoer approved these changes

@bergwolf bergwolf Awaiting requested review from bergwolf bergwolf is a code owner automatically assigned from dragonflyoss/nydus-reviewers

@changweige changweige Awaiting requested review from changweige changweige is a code owner automatically assigned from dragonflyoss/nydus-reviewers

@hsiangkao hsiangkao Awaiting requested review from hsiangkao hsiangkao is a code owner automatically assigned from dragonflyoss/nydus-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jiangliu @anolis-bot @imeoer