Skip to content

feat(nydusify): After converting the image, if the push operation fails, increase the number of retries. #1703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 17, 2025
Merged

feat(nydusify): After converting the image, if the push operation fails, increase the number of retries. #1703

merged 1 commit into from
Jun 17, 2025

Conversation

ymygogogo
Copy link

Details

When the image is too large, during the push process, there might be some issues in the middle, causing a significant amount of time to be spent on conversion each time. To address this problem, a retry mechanism was added during the push process.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

Go over all the following points, and put an x in all the boxes that apply.

  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

@ymygogogo ymygogogo requested a review from a team as a code owner June 4, 2025 06:10
@ymygogogo ymygogogo requested review from imeoer, jiangliu and gaius-qi and removed request for a team June 4, 2025 06:10
@codecov Codecov
Copy link

codecov bot commented Jun 4, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 38.04348% with 57 lines in your changes missing coverage. Please review.

Project coverage is 55.45%. Comparing base (9645820) to head (f97e8bf).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
...ontrib/nydusify/pkg/converter/provider/provider.go 0.00% 21 Missing ⚠️
contrib/nydusify/cmd/nydusify.go 11.11% 16 Missing ⚠️
contrib/nydusify/pkg/utils/utils.go 73.33% 8 Missing and 4 partials ⚠️
contrib/nydusify/pkg/converter/converter.go 0.00% 7 Missing ⚠️
contrib/nydusify/pkg/provider/source.go 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1703      +/-   ##
==========================================
- Coverage   55.51%   55.45%   -0.06%     
==========================================
  Files         197      197              
  Lines       55824    55891      +67     
  Branches    47246    47247       +1     
==========================================
+ Hits        30988    30996       +8     
- Misses      23234    23288      +54     
- Partials     1602     1607       +5
Files with missing lines Coverage Δ
contrib/nydusify/pkg/provider/source.go 0.00% <0.00%> (ø)
contrib/nydusify/pkg/converter/converter.go 64.93% <0.00%> (-1.15%) ⬇️
contrib/nydusify/pkg/utils/utils.go 63.35% <73.33%> (+2.10%) ⬆️
contrib/nydusify/cmd/nydusify.go 17.27% <11.11%> (-0.22%) ⬇️
...ontrib/nydusify/pkg/converter/provider/provider.go 0.00% <0.00%> (ø)

... and 6 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

imeoer
imeoer reviewed Jun 10, 2025
View reviewed changes
imeoer
imeoer reviewed Jun 10, 2025
View reviewed changes
@ymygogogo ymygogogo force-pushed the master branch 6 times, most recently from ce808b1 to 5c2f710 Compare June 10, 2025 17:07
@ymygogogo ymygogogo requested a review from imeoer June 11, 2025 02:59
imeoer
imeoer reviewed Jun 13, 2025
View reviewed changes
Copy link
Collaborator

@imeoer imeoer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We added two retry options, are these necessary for the use case? They might be adding unnecessary complexity to the CLI. :)

@ymygogogo
Copy link
Author

We added two retry options, are these necessary for the use case? They might be adding unnecessary complexity to the CLI. :)

I think this parameter is still necessary. When using it, you can decide whether to add it based on your own needs.

@ymygogogo
Copy link
Author

These two parameters should be very important to me.

We added two retry options, are these necessary for the use case? They might be adding unnecessary complexity to the CLI. :)我们添加了两个重试选项，这些对于用例来说是必要的吗？它们可能会给 CLI 增加不必要的复杂性。:)
These two parameters should be very important to me.

@ymygogogo ymygogogo requested a review from imeoer June 13, 2025 08:48
@ymygogogo ymygogogo force-pushed the master branch 3 times, most recently from 7b946f1 to 297f574 Compare June 13, 2025 09:46
@ymygogogo
Copy link
Author

Please take a look for me again. smoke test doesn't seem to be my problem @imeoer

imeoer
imeoer approved these changes Jun 16, 2025
View reviewed changes
Copy link
Collaborator

@imeoer imeoer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM!

feat(nydusify): After converting the image, if the push operation fai…
f97e8bf 
…ls, increase the number of retries.

Signed-off-by: ymy <ymy@zetyun.com>
@ymygogogo ymygogogo requested a review from imeoer June 17, 2025 09:09
@imeoer imeoer merged commit d589292 into dragonflyoss:master Jun 17, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BraveY BraveY BraveY left review comments

@jiangliu jiangliu Awaiting requested review from jiangliu jiangliu is a code owner automatically assigned from dragonflyoss/nydus-reviewers

@gaius-qi gaius-qi Awaiting requested review from gaius-qi gaius-qi is a code owner automatically assigned from dragonflyoss/nydus-reviewers

@imeoer imeoer Awaiting requested review from imeoer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ymygogogo @imeoer @BraveY