Skip to content

feat(nydusify): A short container id is supported when you commit a container #1674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 10, 2025
Merged

feat(nydusify): A short container id is supported when you commit a container #1674

merged 2 commits into from
Mar 10, 2025

Conversation

ymygogogo
Copy link

Details

A short container id is supported when you commit a container

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

@ymygogogo ymygogogo requested a review from a team as a code owner March 5, 2025 17:14
@ymygogogo ymygogogo requested review from gaius-qi, hsiangkao and power-more and removed request for a team March 5, 2025 17:14
@ymygogogo
Copy link
Author

ymygogogo commented Mar 5, 2025 •
edited
Loading

@imeoer Please help me to check whether it is possible and merge

@codecov Codecov
Copy link

codecov bot commented Mar 6, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 60.41%. Comparing base (8b03fd7) to head (7029b01).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
contrib/nydusify/cmd/nydusify.go 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1674      +/-   ##
==========================================
- Coverage   60.42%   60.41%   -0.01%     
==========================================
  Files         146      146              
  Lines       48943    48943              
  Branches    46380    46380              
==========================================
- Hits        29573    29571       -2     
- Misses      17906    17907       +1     
- Partials     1464     1465       +1
Files with missing lines Coverage Δ
contrib/nydusify/cmd/nydusify.go 13.52% <0.00%> (ø)

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

BraveY
BraveY reviewed Mar 6, 2025
View reviewed changes
imeoer
imeoer reviewed Mar 6, 2025
View reviewed changes
Optimize: Improve code style in push lower blob section
a6e7257 
Signed-off-by: ymy <ymy@zetyun.com>
@ymygogogo
Copy link
Author

I look OK,please review it for me. @imeoer @BraveY (●'◡'●)

@ymygogogo ymygogogo requested review from imeoer and BraveY March 7, 2025 02:23
BraveY
BraveY reviewed Mar 7, 2025
View reviewed changes
feat(nydusify): A short container id is supported when you commit a c…
7029b01 
…ontainer

Signed-off-by: ymy <ymy@zetyun.com>
@ymygogogo ymygogogo requested a review from BraveY March 9, 2025 13:56
BraveY
BraveY approved these changes Mar 10, 2025
View reviewed changes
Copy link
Contributor

@BraveY BraveY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BraveY BraveY merged commit 7e51479 into dragonflyoss:master Mar 10, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BraveY BraveY BraveY approved these changes

@gaius-qi gaius-qi Awaiting requested review from gaius-qi gaius-qi is a code owner automatically assigned from dragonflyoss/nydus-reviewers

@hsiangkao hsiangkao Awaiting requested review from hsiangkao hsiangkao is a code owner automatically assigned from dragonflyoss/nydus-reviewers

@power-more power-more Awaiting requested review from power-more power-more is a code owner automatically assigned from dragonflyoss/nydus-reviewers

@imeoer imeoer Awaiting requested review from imeoer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ymygogogo @imeoer @BraveY