Support CRC32 validation for both RAFS V5 and V6. #1670
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b34dc5d to
631049c
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1670 +/- ##
==========================================
+ Coverage 55.31% 55.34% +0.03%
==========================================
Files 196 197 +1
Lines 55347 55706 +359
Branches 46817 47176 +359
==========================================
+ Hits 30614 30833 +219
- Misses 23143 23273 +130
- Partials 1590 1600 +10
🚀 New features to boost your workflow:
|
imeoer
reviewed
Apr 14, 2025
imeoer
reviewed
Apr 16, 2025
builder/src/chunkdict_generator.rs
Outdated
| @@ -270,6 +270,7 @@ impl Generator { | |||
| chunk.set_uncompressed_size(chunk_info.chunk_uncompressed_size); | |||
| chunk.set_uncompressed_offset(chunk_info.chunk_uncompressed_offset); | |||
| chunk.set_id(RafsDigest::from_string(&chunk_info.chunk_digest)); | |||
| // TODO: set crc32 of chunk. | |||
builder/src/core/node.rs
Outdated
| @@ -337,6 +337,10 @@ impl Node { | |||
| external_compressed_offset += compressed_size as u64; | |||
| external_blob_ctx.chunk_size = external_chunk_size as u32; | |||
|
|
|||
| if ctx.crc_checker != crc::Algorithm::None { | |||
There was a problem hiding this comment.
crc_checker -> crc_algorithm
rafs/src/metadata/layout/v6.rs
Outdated
| @@ -583,6 +583,15 @@ impl RafsV6SuperBlockExt { | |||
| self.s_flags |= c.bits(); | |||
| } | |||
|
|
|||
| /// Set CRC algorithm to handle chunk of the Rafs filesystem. | |||
| pub fn set_crc_checker(&mut self, crc_algo: crc::Algorithm) { | |||
- Add CRC32 algorithm implementation wiht crc-rs crate. - Introduced a crc_enable option to the nydus builder. - Support for generating CRC32 checksums when building images. - Support for validating CRC32 in both normal chunk or external chunks. Signed-off-by: Yang Kaiyong <yangkaiyong.yky@antgroup.com>
cfb2067 to
3e56b46
Compare
imeoer
reviewed
Apr 18, 2025
Signed-off-by: Yang Kaiyong <yangkaiyong.yky@antgroup.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant Issue (if applicable)
If there are Issues related to this PullRequest, please list it.
Details
Please describe the details of PullRequest.
In P2P transmission, errors in the pulled Chunk information may occur due to network issues or other reasons. To address this, CRC32 has been introduced to verify the integrity of Chunk data. Compared to the case without enabling verification, using CRC32 increases the processing time by approximately 5.6%, which is an acceptable overhead.
Types of changes
What types of changes does your PullRequest introduce? Put an
xin all the boxes that apply:Checklist
Go over all the following points, and put an
xin all the boxes that apply.