nydus-image: modify compact interface #1631
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit uses compact parameter directly insteadof compact config file in the cli interface. It also fix a bug where chunk key for ChunkWrapper::Ref is not generated correctly. Signed-off-by: Yifan Zhao <zhaoyifan@sjtu.edu.cn>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1631 +/- ##
==========================================
- Coverage 61.29% 61.24% -0.05%
==========================================
Files 146 146
Lines 48156 48189 +33
Branches 46123 46156 +33
==========================================
- Hits 29516 29513 -3
- Misses 17084 17115 +31
- Partials 1556 1561 +5
|
imeoer
reviewed
Oct 10, 2024
src/bin/nydus-image/main.rs
Outdated
| .group("backend"), | ||
| Arg::new("min-used-ratio") | ||
| .long("min-used-ratio") | ||
| .help("Lower bound of used ratio for blobs to be kept") |
There was a problem hiding this comment.
May be add some help hint: Lower bound of used ratio for blobs to be kept, possible values: 0-99, 0 means disable.
src/bin/nydus-image/main.rs
Outdated
| .arg( | ||
| Arg::new("compact-blob-size") | ||
| .long("compact-blob-size") | ||
| .help("Upper bound of blob size for blobs to be compacted") |
There was a problem hiding this comment.
Upper bound of blob size for blobs to be compacted, in bytes.
src/bin/nydus-image/main.rs
Outdated
| .arg( | ||
| Arg::new("max-compact-size") | ||
| .long("max-compact-size") | ||
| .help("Upper bound of compacted blob size") |
There was a problem hiding this comment.
Upper bound of compacted blob size, in bytes.
This patch modifies the compact interface to meet the change in nydus-image. Signed-off-by: Yifan Zhao <zhaoyifan@sjtu.edu.cn>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit uses compact parameter directly insteadof compact config file in the cli interface. It also fix a bug where chunk key for ChunkWrapper::Ref is not generated correctly.
Types of changes
What types of changes does your PullRequest introduce? Put an
xin all the boxes that apply: