Skip to content

Conversation

chlins
Copy link
Member

@chlins chlins commented Aug 20, 2025

This pull request updates several components to use newer versions and introduces a minor configuration change to improve compatibility and cluster identification. The most important changes are grouped below:

Version Updates:

  • Updated Docker image tags for manager, scheduler, client, and seed-client modules in .github/workflows/compatibility-e2e.yml to newer release candidates and client versions.
  • Updated the submodule reference for client-rs to the latest commit.
  • Updated the submodule reference for deploy/helm-charts to the latest commit.

Configuration Improvements:

  • Added the schedulerClusterID: 1 configuration under host for both seedClient and client sections in test/testdata/charts/config.yaml to ensure proper cluster identification. [1] [2]

Description

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@chlins chlins added the enhancement New feature or request label Aug 20, 2025
Copy link

codecov bot commented Aug 20, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 32.61%. Comparing base (e169394) to head (0e68750).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4275      +/-   ##
==========================================
- Coverage   32.62%   32.61%   -0.01%     
==========================================
  Files         349      349              
  Lines       41368    41368              
==========================================
- Hits        13496    13492       -4     
- Misses      26996    26998       +2     
- Partials      876      878       +2     
Flag Coverage Δ
unittests 32.61% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@chlins chlins force-pushed the chore/bump-to-v2.3.1-rc.4 branch from a184895 to 6ad2f5a Compare August 20, 2025 10:09
Signed-off-by: chlins <chlins.zhang@gmail.com>
@chlins chlins force-pushed the chore/bump-to-v2.3.1-rc.4 branch from 6ad2f5a to 0e68750 Compare August 20, 2025 12:09
Copy link
Contributor

@LunaWhispers LunaWhispers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@LunaWhispers LunaWhispers enabled auto-merge (squash) August 20, 2025 13:18
Copy link
Member

@gaius-qi gaius-qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@LunaWhispers LunaWhispers merged commit 0e01bf8 into main Aug 20, 2025
16 checks passed
@LunaWhispers LunaWhispers deleted the chore/bump-to-v2.3.1-rc.4 branch August 20, 2025 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants