refactor: remove unused seed peer related logic #4259
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4259 +/- ##
==========================================
+ Coverage 32.42% 32.61% +0.19%
==========================================
Files 350 349 -1
Lines 41630 41363 -267
==========================================
- Hits 13497 13492 -5
+ Misses 27257 26993 -264
- Partials 876 878 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Signed-off-by: chlins <chlins.zhang@gmail.com>
d36f593 to
3aef3bf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request removes the custom gRPC seed peer resolver implementation and its related usage from the codebase. The main impact is a simplification of the client connection logic for seed peers, as well as the cleanup of related interfaces and mock methods. The changes affect several packages, including the scheduler configuration and RPC client modules.
Removal of custom gRPC resolver and related logic
pkg/resolver/seed_peer_resolver.gofile, which previously implemented a custom gRPC resolver for seed peers. This includes the resolver registration, address resolution, and notification logic.GetResolveSeedPeerAddrsmethod from theDynconfigInterfaceinscheduler/config/dynconfig.go, along with its implementation and associated imports. This method was used to provide dynamic addresses for the custom resolver. [1] [2] [3]GetClientandGetV2methods inpkg/rpc/cdnsystem/client/client.goandpkg/rpc/dfdaemon/client/client_v2.go, simplifying the client creation logic. [1] [2] [3]GetResolveSeedPeerAddrsfrom the generated mock forDynconfigInterfaceinscheduler/config/mocks/dynconfig_mock.go. [1] [2]Miscellaneous cleanup
GetSeedPeerClusterConfigBySeedPeerfromscheduler/config/dynconfig.go, further simplifying the configuration code.Description
Related Issue
Motivation and Context
Screenshots (if appropriate)
Types of changes
Checklist