Skip to content

Conversation

gaius-qi
Copy link
Member

@gaius-qi gaius-qi commented Aug 6, 2025

Description

This pull request makes a small change to the Peer struct in manager/types/job.go to improve the clarity and consistency of JSON field naming.

  • Renamed the JSON field tag for the CachedLayers member from "layers" to "cached_layers" in the Peer struct to better reflect its purpose and improve naming consistency.

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

…d_layers"

Signed-off-by: Gaius <gaius.qi@gmail.com>
@gaius-qi gaius-qi added this to the v2.4.0 milestone Aug 6, 2025
@gaius-qi gaius-qi self-assigned this Aug 6, 2025
@gaius-qi gaius-qi added the enhancement New feature or request label Aug 6, 2025
Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chlins chlins enabled auto-merge (squash) August 6, 2025 08:00
Copy link
Contributor

@LunaWhispers LunaWhispers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link

codecov bot commented Aug 6, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 32.91%. Comparing base (88dc8e1) to head (00c719d).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4258      +/-   ##
==========================================
- Coverage   32.91%   32.91%   -0.01%     
==========================================
  Files         352      352              
  Lines       41781    41781              
==========================================
- Hits        13754    13751       -3     
- Misses      27137    27138       +1     
- Partials      890      892       +2     
Flag Coverage Δ
unittests 32.91% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@chlins chlins merged commit b3e8695 into main Aug 6, 2025
18 checks passed
@chlins chlins deleted the feature/cache branch August 6, 2025 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants