feat: Moved preheatImage struct and parseManifestURL from manager/job/types.go to internal/job/image.go for better encapsulation #4243
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
42a73ee to
3646f17
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4243 +/- ##
=======================================
Coverage 32.50% 32.50%
=======================================
Files 350 350
Lines 41382 41382
=======================================
Hits 13453 13453
Misses 27038 27038
Partials 891 891
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
BruceAko
previously approved these changes
Jul 29, 2025
…/types.go to internal/job/image.go for better encapsulation Signed-off-by: Gaius <gaius.qi@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request introduces significant refactoring and modularization of the preheat functionality for container images, primarily by moving the image-related logic to a new internal package and simplifying the
preheatjob implementation. Additionally, it introduces OpenTelemetry tracing for better observability.Refactoring and Modularization
Moved the image-related logic, including manifest parsing, authentication, and layer extraction, to the new
internal/job/image.gofile. This includes functions likeCreatePreheatRequestsByManifestURL,resolveManifests, andbuildPreheatRequestFromManifestsas well as supporting types likepreheatImageandimageAuthClient.Removed the redundant
GetImageLayersfunction and related logic frommanager/job/preheat.go, replacing it with a call tointernaljob.GetImageLayers, which encapsulates the same functionality in the new internal module. [1] [2]Observability
tracer) ininternal/job/job.gofor thejobpackage, enabling distributed tracing for preheat-related operations.Code Simplification
manager/job/preheat.go, as these are now handled within the new internal module. [1] [2]Related Issue
Motivation and Context
Screenshots (if appropriate)
Types of changes
Checklist