refactor(job): use goroutine to unmarshal task result #4245
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4245 +/- ##
==========================================
+ Coverage 32.52% 32.90% +0.38%
==========================================
Files 350 352 +2
Lines 41382 41781 +399
==========================================
+ Hits 13459 13748 +289
- Misses 27034 27140 +106
- Partials 889 893 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
chlins
reviewed
Aug 4, 2025
chlins
reviewed
Aug 4, 2025
gaius-qi
requested changes
Aug 5, 2025
Signed-off-by: jinronga <1460595002@qq.com> Signed-off-by: “jinrong” <1460595002@qq.com>
- Use `errgroup` instead of `sync.WaitGroup` and `sync.Once` - Optimize error handling logic to directly return the first error - Adjust variable scope to avoid potential loop variable capture issues - Code style adjustments to improve readability Signed-off-by: “jinrong” <1460595002@qq.com>
- Add GroupJobStateConcurrencyLimit constant to limit the number of concurrent goroutines - Implement the concurrency limit in GetGroupJobState function using errgroup - Refactor error handling in task result unmarshalling for better readability Signed-off-by: “jinrong” <1460595002@qq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Motivation and Context
Screenshots (if appropriate)
Types of changes
Checklist