Skip to content

feat: add RemoteIp for calling client #4231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 22, 2025
Merged

feat: add RemoteIp for calling client #4231

merged 2 commits into from
Jul 22, 2025

Conversation

gaius-qi
Copy link
Member

Description

This pull request introduces changes to update a dependency version and enhance the handling of server IP addresses in various scheduler operations. The most significant updates include upgrading the d7y.io/api/v2 dependency and consistently passing the server's AdvertiseIP as RemoteIp in multiple scheduler methods.

Dependency Update:

  • Updated d7y.io/api/v2 from version v2.1.42 to v2.1.47 in go.mod to incorporate the latest features and fixes.

Enhancements to Scheduler Operations:

  • Preheat Operations:

    • Added the server's AdvertiseIP as RemoteIp in preheatV2SingleSeedPeerByURL, preheatAllSeedPeers, and preheatAllPeers methods to ensure accurate network communication. (scheduler/job/job.go: [1] [2] [3] [4] [5] [6]

  • Task Deletion:

    • Included AdvertiseIP as RemoteIp in deleteTask and DeletePersistentCacheTask methods for improved task management. (scheduler/job/job.go: [1] scheduler/service/service_v2.go: [2]

  • Persistent Cache Operations:

    • Passed AdvertiseIP as RemoteIp in methods handling persistent cache tasks, such as DeletePersistentCachePeer, downloadPersistentCacheTaskByPeer, and persistPersistentCacheTaskByPeer, to enhance consistency and reliability. (scheduler/service/service_v2.go: [1] [2] [3]

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@gaius-qi
feat: add RemoteIp for calling client
1169c94 
Signed-off-by: Gaius <gaius.qi@gmail.com>
@gaius-qi gaius-qi added this to the v2.4.0 milestone Jul 22, 2025
@gaius-qi gaius-qi self-assigned this Jul 22, 2025
@gaius-qi gaius-qi added the enhancement New feature or request label Jul 22, 2025
@gaius-qi gaius-qi requested a review from a team as a code owner July 22, 2025 08:32
LunaWhispers
LunaWhispers previously approved these changes Jul 22, 2025
View reviewed changes
Copy link
Contributor

@LunaWhispers LunaWhispers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

chlins
chlins previously approved these changes Jul 22, 2025
View reviewed changes
Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@LunaWhispers LunaWhispers enabled auto-merge (squash) July 22, 2025 08:36
Liam-Zhao
Liam-Zhao previously approved these changes Jul 22, 2025
View reviewed changes
Copy link

@Liam-Zhao Liam-Zhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

BruceAko
BruceAko previously approved these changes Jul 22, 2025
View reviewed changes
@gaius-qi
Merge branch 'main' of github.com:dragonflyoss/dragonfly into feature…
e498dfc 
…/remote-ip

Signed-off-by: Gaius <gaius.qi@gmail.com>
@gaius-qi gaius-qi dismissed stale reviews from BruceAko, Liam-Zhao, chlins, and LunaWhispers via e498dfc July 22, 2025 08:38
LunaWhispers
LunaWhispers approved these changes Jul 22, 2025
View reviewed changes
Copy link
Contributor

@LunaWhispers LunaWhispers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

chlins
chlins approved these changes Jul 22, 2025
View reviewed changes
Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov Codecov
Copy link

codecov bot commented Jul 22, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 17 lines in your changes missing coverage. Please review.

Project coverage is 32.51%. Comparing base (688f64c) to head (e498dfc).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
scheduler/job/job.go 0.00% 9 Missing ⚠️
scheduler/service/service_v2.go 0.00% 8 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4231      +/-   ##
==========================================
- Coverage   32.54%   32.51%   -0.03%     
==========================================
  Files         350      350              
  Lines       41346    41360      +14     
==========================================
- Hits        13454    13449       -5     
- Misses      27003    27019      +16     
- Partials      889      892       +3
Flag Coverage Δ
unittests 32.51% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
scheduler/service/service_v2.go 46.17% <0.00%> (-0.13%) ⬇️
scheduler/job/job.go 0.00% <0.00%> (ø)

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@LunaWhispers LunaWhispers merged commit 41da9b7 into main Jul 22, 2025
16 of 17 checks passed
@LunaWhispers LunaWhispers deleted the feature/remote-ip branch July 22, 2025 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chlins chlins chlins approved these changes

@LunaWhispers LunaWhispers LunaWhispers approved these changes

@BruceAko BruceAko BruceAko left review comments

@Liam-Zhao Liam-Zhao Liam-Zhao left review comments

@allencloud allencloud Awaiting requested review from allencloud allencloud was automatically assigned from dragonflyoss/dragonfly-approvers

@hyy0322 hyy0322 Awaiting requested review from hyy0322 hyy0322 was automatically assigned from dragonflyoss/dragonfly-approvers

@fcgxz2003 fcgxz2003 Awaiting requested review from fcgxz2003 fcgxz2003 was automatically assigned from dragonflyoss/dragonfly-approvers

Assignees

@xujihui1985 xujihui1985

@yxxhero yxxhero

@gaius-qi gaius-qi

@chlins chlins

Labels
enhancement New feature or request
Projects
None yet
Milestone
v2.4.0
Development

Successfully merging this pull request may close these issues.
7 participants
@gaius-qi @chlins @BruceAko @LunaWhispers @Liam-Zhao @xujihui1985 @yxxhero