fix: revert the remove of ip and port in mamager rpc server #4180
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: chlins <chlins.zhang@gmail.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4180 +/- ##
==========================================
- Coverage 32.85% 32.85% -0.01%
==========================================
Files 350 350
Lines 41060 41064 +4
==========================================
Hits 13491 13491
- Misses 26675 26679 +4
Partials 894 894
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the
managerServerV2RPC server to include additional fields (IPandPort) when querying forSeedPeerandSchedulerrecords. These changes ensure more precise matching of records in the database.Enhancements to database queries:
manager/rpcserver/manager_server_v2.go: Updated theUpdateSeedPeermethod to includeIPandPortin the query criteria for retrievingSeedPeerrecords.manager/rpcserver/manager_server_v2.go: Updated theUpdateSchedulermethod to includeIPandPortin the query criteria for retrievingSchedulerrecords.Description
Related Issue
Motivation and Context
Screenshots (if appropriate)
Types of changes
Checklist