fix: populate the User from UserID when get application and job #4178
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: chlins <chlins.zhang@gmail.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4178 +/- ##
==========================================
- Coverage 32.90% 32.85% -0.06%
==========================================
Files 347 350 +3
Lines 40992 41064 +72
==========================================
+ Hits 13490 13491 +1
- Misses 26608 26679 +71
Partials 894 894
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces changes to the
ApplicationandJobmodels in themanager/modelspackage to improve how relatedUserdata is handled. The most significant updates include marking theUserfield withgorm:"-"to exclude it from ORM operations and addingAfterFindhooks to populate theUserfield after database queries.Changes to
Applicationmodel:Userfield withgorm:"-"to exclude it from ORM operations. (manager/models/application.go, manager/models/application.goR19-R42)AfterFindhook to populate theUserfield after database queries by fetching the associatedUserbased onUserID. (manager/models/application.go, manager/models/application.goR19-R42)Changes to
Jobmodel:Userfield withgorm:"-"to exclude it from ORM operations. (manager/models/job.go, manager/models/job.goL28-R47)AfterFindhook to populate theUserfield after database queries by fetching the associatedUserbased onUserID. (manager/models/job.go, manager/models/job.goL28-R47)Description
Related Issue
Closes #4171
Motivation and Context
Screenshots (if appropriate)
Types of changes
Checklist