Skip to content

Conversation

chlins
Copy link
Member

@chlins chlins commented Jun 30, 2025

This pull request makes a small but important change to the RunGC method in manager/gc/job.go. The change updates the default task ID used in background periodic execution scenarios to ensure it aligns with the correct identifier.

  • manager/gc/job.go: Replaced AuditGCTaskID with JobGCTaskID as the default task ID in the RunGC method.

Description

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

Signed-off-by: chlins <chlins.zhang@gmail.com>
Copy link

@Liam-Zhao Liam-Zhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Liam-Zhao Liam-Zhao enabled auto-merge (squash) June 30, 2025 08:02
@gaius-qi gaius-qi added the enhancement New feature or request label Jun 30, 2025
Copy link
Member

@gaius-qi gaius-qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Jun 30, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 32.94%. Comparing base (f7f832c) to head (f5287fd).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
manager/gc/job.go 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4163      +/-   ##
==========================================
- Coverage   32.96%   32.94%   -0.02%     
==========================================
  Files         346      346              
  Lines       40945    40945              
==========================================
- Hits        13497    13491       -6     
- Misses      26556    26560       +4     
- Partials      892      894       +2     
Flag Coverage Δ
unittests 32.94% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
manager/gc/job.go 0.00% <0.00%> (ø)

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Liam-Zhao Liam-Zhao merged commit 913e27d into main Jun 30, 2025
17 of 19 checks passed
@Liam-Zhao Liam-Zhao deleted the fix/gc-job-task-id branch June 30, 2025 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants