feat: support HTTPS protocol for otel #4159
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4159 +/- ##
=======================================
Coverage 32.94% 32.94%
=======================================
Files 346 346
Lines 40939 40945 +6
=======================================
+ Hits 13488 13490 +2
- Misses 26557 26561 +4
Partials 894 894
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Signed-off-by: Gaius <gaius.qi@gmail.com>
3b763db to
aea78a9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request introduces updates to the tracing configuration across multiple components in the codebase. The key changes include adding a
Pathfield to theTracingConfigstruct, modifying the initialization logic for HTTP and HTTPS tracing exporters to support the newPathfield, and removing outdated tracing configuration sections from various Docker Compose templates.Updates to tracing configuration:
Added
Pathfield toTracingConfig: Introduced a newPathfield in theTracingConfigstruct to specify the URL path for the tracing server (e.g.,/v1/traces). (cmd/dependency/base/option.go, cmd/dependency/base/option.goR35-R37)Updated tracing exporter initialization: Modified the
initJaegerTracerfunction to utilize the newPathfield for HTTP and HTTPS tracing protocols. This ensures the correct URL path is used when creating the trace exporter. (cmd/dependency/dependency.go, cmd/dependency/dependency.goL154-R160)Cleanup in Docker Compose templates:
deploy/docker-compose/template/client.template.yaml, [1];deploy/docker-compose/template/manager.template.yaml, [2];deploy/docker-compose/template/scheduler.template.yaml, [3];deploy/docker-compose/template/seed-client.template.yaml, [4]Default tracing path in configurations:
Pathvalue (/v1/traces) to the tracing configuration in both the manager and scheduler components. (manager/config/config.go, [1];scheduler/config/config.go, [2]Related Issue
Motivation and Context
Screenshots (if appropriate)
Types of changes
Checklist