Skip to content

feat: add logLevel and remove verbose #4157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 24, 2025
Merged

feat: add logLevel and remove verbose #4157

merged 1 commit into from
Jun 24, 2025

Conversation

gaius-qi
Copy link
Member

Description

This pull request includes changes to the dfcache and dfget documentation and configuration files, focusing on removing deprecated options, updating network terminology, and enhancing logging configuration. The most important changes include removing the pprof-port and verbose options, updating references to the P2P network, and adding a new LogLevel configuration option.

Deprecated Options Removal:

  • Removed the pprof-port option across all dfcache and dfget documentation files, as it is no longer supported. ([[1]](https://github.com/dragonflyoss/dragonfly/pull/4157/files#diff-a99409cf4b38ee1750d03a6d6e3ea8a0f32704272306e3a774088ddc0fb9cd56L19-L22), [[2]](https://github.com/dragonflyoss/dragonfly/pull/4157/files#diff-2772111a83fad318e6250def6015c5849de7df9ed7a2b7d8ab63d29709fe1b7dL19-L22), [[3]](https://github.com/dragonflyoss/dragonfly/pull/4157/files#diff-63d67c5e8fe4b14b40ed0502fc12f305ff79ab27af5401458f57a21117607ddbL19-L22), [[4]](https://github.com/dragonflyoss/dragonfly/pull/4157/files#diff-b41908d4bf50b84e21443eb45d23135e9c447254ef0def8091dbe9165197b566L19-L22), [[5]](https://github.com/dragonflyoss/dragonfly/pull/4157/files#diff-60d44573cc007d3ba81ac7f8084ed0e013a46c2cf5cd5a2aa628c64028685779L19-L22), [[6]](https://github.com/dragonflyoss/dragonfly/pull/4157/files#diff-928feef7c89ecf1808291eebdb0285538a5578dce4a02e4394a86ead567330ffL20-L23), [[7]](https://github.com/dragonflyoss/dragonfly/pull/4157/files#diff-e71ee67f445bc9be1f09930a0e2aa3c114b8a1e49d1c498b027dc365f5a0e581L19-L22), [[8]](https://github.com/dragonflyoss/dragonfly/pull/4157/files#diff-47843daebd11d6f62965644dafcc34f4bc7f7d4c8539542f9e771a70d08d88e9L26-L29), [[9]](https://github.com/dragonflyoss/dragonfly/pull/4157/files#diff-3a8055323637a620c1683c389730b1ae556d8be8bb8a572a404aed9907eb3791L26-L29), [[10]](https://github.com/dragonflyoss/dragonfly/pull/4157/files#diff-7d3125fe272cf83c73c9e80d2de2b4f1b7751b89b87c8bc20627ec4f419a1568L22-L25), [[11]](https://github.com/dragonflyoss/dragonfly/pull/4157/files#diff-6ec7f73ceed7af9d5e07e57274142ce00dfc4e8243ae343325d9d7977c1dce51L22-L25), [[12]](https://github.com/dragonflyoss/dragonfly/pull/4157/files#diff-f0715a542b716120f1d546665f0a1c98d5f61a2a3695f350c053cceea2a36e11L22-L25), [[13]](https://github.com/dragonflyoss/dragonfly/pull/4157/files#diff-a7d23849cd6a4dddba25c97232927e59eccfd8d57e67986a362b5f0ab8ca26b5L22-L25), [[14]](https://github.com/dragonflyoss/dragonfly/pull/4157/files#diff-ede63f343dfb79de9d20c8c5788668b1ed9137a92db16550041e3ba13e99b7baL22-L25), [[15]](https://github.com/dragonflyoss/dragonfly/pull/4157/files#diff-c16e1393d1c8b09457cff16793870538af8ebf19985fbb73ca4ba4a40f3eab53L22-L25), [[16]](https://github.com/dragonflyoss/dragonfly/pull/4157/files#diff-79a0d8dd15dbe8963ccb2505c4ecd74b8bd58c3e9b873a5fe053e57b87029063L22-L25), [[17]](https://github.com/dragonflyoss/dragonfly/pull/4157/files#diff-25f6e66a3a58fb7d3ca41bed0a8047dec97c55c7e4257c431669a13748a3ff29L35), [[18]](https://github.com/dragonflyoss/dragonfly/pull/4157/files#diff-eabf4040306e859c0af851b06b0511e5771d851ffb46d21e33e933b385921a3aL32))
  • Removed the verbose option from documentation files, simplifying logging configuration. ([[1]](https://github.com/dragonflyoss/dragonfly/pull/4157/files#diff-a99409cf4b38ee1750d03a6d6e3ea8a0f32704272306e3a774088ddc0fb9cd56L19-L22), [[2]](https://github.com/dragonflyoss/dragonfly/pull/4157/files#diff-2772111a83fad318e6250def6015c5849de7df9ed7a2b7d8ab63d29709fe1b7dL19-L22), [[3]](https://github.com/dragonflyoss/dragonfly/pull/4157/files#diff-63d67c5e8fe4b14b40ed0502fc12f305ff79ab27af5401458f57a21117607ddbL19-L22), [[4]](https://github.com/dragonflyoss/dragonfly/pull/4157/files#diff-b41908d4bf50b84e21443eb45d23135e9c447254ef0def8091dbe9165197b566L19-L22), [[5]](https://github.com/dragonflyoss/dragonfly/pull/4157/files#diff-60d44573cc007d3ba81ac7f8084ed0e013a46c2cf5cd5a2aa628c64028685779L19-L22), [[6]](https://github.com/dragonflyoss/dragonfly/pull/4157/files#diff-928feef7c89ecf1808291eebdb0285538a5578dce4a02e4394a86ead567330ffL20-L23), [[7]](https://github.com/dragonflyoss/dragonfly/pull/4157/files#diff-e71ee67f445bc9be1f09930a0e2aa3c114b8a1e49d1c498b027dc365f5a0e581L19-L22), [[8]](https://github.com/dragonflyoss/dragonfly/pull/4157/files#diff-47843daebd11d6f62965644dafcc34f4bc7f7d4c8539542f9e771a70d08d88e9L26-L29), [[9]](https://github.com/dragonflyoss/dragonfly/pull/4157/files#diff-3a8055323637a620c1683c389730b1ae556d8be8bb8a572a404aed9907eb3791L26-L29), [[10]](https://github.com/dragonflyoss/dragonfly/pull/4157/files#diff-7d3125fe272cf83c73c9e80d2de2b4f1b7751b89b87c8bc20627ec4f419a1568L22-L25), [[11]](https://github.com/dragonflyoss/dragonfly/pull/4157/files#diff-6ec7f73ceed7af9d5e07e57274142ce00dfc4e8243ae343325d9d7977c1dce51L22-L25), [[12]](https://github.com/dragonflyoss/dragonfly/pull/4157/files#diff-f0715a542b716120f1d546665f0a1c98d5f61a2a3695f350c053cceea2a36e11L22-L25), [[13]](https://github.com/dragonflyoss/dragonfly/pull/4157/files#diff-a7d23849cd6a4dddba25c97232927e59eccfd8d57e67986a362b5f0ab8ca26b5L22-L25), [[14]](https://github.com/dragonflyoss/dragonfly/pull/4157/files#diff-ede63f343dfb79de9d20c8c5788668b1ed9137a92db16550041e3ba13e99b7baL22-L25), [[15]](https://github.com/dragonflyoss/dragonfly/pull/4157/files#diff-c16e1393d1c8b09457cff16793870538af8ebf19985fbb73ca4ba4a40f3eab53L22-L25), [[16]](https://github.com/dragonflyoss/dragonfly/pull/4157/files#diff-79a0d8dd15dbe8963ccb2505c4ecd74b8bd58c3e9b873a5fe053e57b87029063L22-L25), [[17]](https://github.com/dragonflyoss/dragonfly/pull/4157/files#diff-25f6e66a3a58fb7d3ca41bed0a8047dec97c55c7e4257c431669a13748a3ff29L44), [[18]](https://github.com/dragonflyoss/dragonfly/pull/4157/files#diff-eabf4040306e859c0af851b06b0511e5771d851ffb46d21e33e933b385921a3aL41))

Network Terminology Update:

  • Updated the description of the tag option in dfcache export documentation to reference the "P3P network" instead of the "P2P network." ([[1]](https://github.com/dragonflyoss/dragonfly/pull/4157/files#diff-63d67c5e8fe4b14b40ed0502fc12f305ff79ab27af5401458f57a21117607ddbL19-L22), [[2]](https://github.com/dragonflyoss/dragonfly/pull/4157/files#diff-f0715a542b716120f1d546665f0a1c98d5f61a2a3695f350c053cceea2a36e11L22-L25))

Logging Enhancements:

  • Added a new LogLevel configuration option in dfcache.go, allowing users to specify log levels such as "debug," "info," "warn," and others. ([client/config/dfcache.goR55-R57](https://github.com/dragonflyoss/dragonfly/pull/4157/files#diff-572f67ece41fd2c52e9bcf5762e6f7a40af95ce1a87144e526aae1c2d87c5014R55-R57))
  • Removed the verbose and log-level settings from dfget.yaml and replaced them with LogLevel for consistency. ([build/package/nfpm/config/dfget.yamlL28-L29](https://github.com/dragonflyoss/dragonfly/pull/4157/files#diff-7ff0d74657a1252ae360e1b4ef2adf13b5f5e12a6e413cc60f1a9f6eabbfebaaL28-L29))

Related Issue

Motivation and Context

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@gaius-qi gaius-qi added this to the v2.3.0 milestone Jun 24, 2025
@gaius-qi gaius-qi self-assigned this Jun 24, 2025
@gaius-qi gaius-qi requested a review from a team as a code owner June 24, 2025 05:42
@gaius-qi gaius-qi added the enhancement New feature or request label Jun 24, 2025
@gaius-qi
feat: add logLevel and remove verbose
7223d94 
Signed-off-by: Gaius <gaius.qi@gmail.com>
@codecov Codecov
Copy link

codecov bot commented Jun 24, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 8.82353% with 31 lines in your changes missing coverage. Please review.

Project coverage is 32.94%. Comparing base (1ba7014) to head (7223d94).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
internal/dflog/loginit.go 0.00% 17 Missing ⚠️
cmd/dfget/cmd/root.go 0.00% 3 Missing ⚠️
cmd/dfcache/cmd/root.go 0.00% 2 Missing ⚠️
pkg/log/log.go 0.00% 2 Missing ⚠️
client/daemon/objectstorage/objectstorage.go 0.00% 1 Missing ⚠️
cmd/dfget/cmd/daemon.go 0.00% 1 Missing ⚠️
cmd/manager/cmd/root.go 0.00% 1 Missing ⚠️
cmd/scheduler/cmd/root.go 0.00% 1 Missing ⚠️
internal/dflog/logcore.go 0.00% 1 Missing ⚠️
manager/database/mysql.go 0.00% 1 Missing ⚠️
... and 1 more
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4157      +/-   ##
==========================================
- Coverage   32.95%   32.94%   -0.01%     
==========================================
  Files         346      346              
  Lines       40949    40939      -10     
==========================================
- Hits        13493    13489       -4     
+ Misses      26564    26556       -8     
- Partials      892      894       +2
Flag Coverage Δ
unittests 32.94% <8.82%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
client/config/dfcache.go 0.00% <ø> (ø)
client/config/dfget.go 76.22% <ø> (ø)
client/config/peerhost.go 42.21% <ø> (ø)
client/daemon/upload/upload_manager.go 54.00% <100.00%> (-0.31%) ⬇️
cmd/dependency/dependency.go 0.00% <ø> (ø)
internal/dflog/logger.go 60.00% <ø> (ø)
manager/config/config.go 96.45% <100.00%> (ø)
scheduler/config/config.go 86.60% <100.00%> (ø)
client/daemon/objectstorage/objectstorage.go 0.00% <0.00%> (ø)
cmd/dfget/cmd/daemon.go 0.00% <0.00%> (ø)
... and 9 more

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

chlins
chlins approved these changes Jun 24, 2025
View reviewed changes
Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Liam-Zhao
Liam-Zhao approved these changes Jun 24, 2025
View reviewed changes
Copy link

@Liam-Zhao Liam-Zhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Liam-Zhao Liam-Zhao enabled auto-merge (squash) June 24, 2025 06:44
@Liam-Zhao Liam-Zhao merged commit 4e65b41 into main Jun 24, 2025
20 of 21 checks passed
@Liam-Zhao Liam-Zhao deleted the feature/log branch June 24, 2025 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chlins chlins chlins approved these changes

@Liam-Zhao Liam-Zhao Liam-Zhao approved these changes

@garenwen garenwen Awaiting requested review from garenwen garenwen was automatically assigned from dragonflyoss/dragonfly-approvers

@KubeStacker KubeStacker Awaiting requested review from KubeStacker KubeStacker was automatically assigned from dragonflyoss/dragonfly-approvers

@fcgxz2003 fcgxz2003 Awaiting requested review from fcgxz2003 fcgxz2003 was automatically assigned from dragonflyoss/dragonfly-approvers

Assignees

@jim3ma jim3ma

@xujihui1985 xujihui1985

@yxxhero yxxhero

@gaius-qi gaius-qi

Labels
enhancement New feature or request
Projects
None yet
Milestone
v2.3.0
Development

Successfully merging this pull request may close these issues.
6 participants
@gaius-qi @chlins @Liam-Zhao @jim3ma @xujihui1985 @yxxhero