fix: set persistent_cache_task_id to 64 bytes #1316
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: LunaWhispers <yangmuyucs@gmail.com>
|
ref: #1281 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1316 +/- ##
=======================================
Coverage 48.58% 48.58%
=======================================
Files 60 60
Lines 15186 15186
=======================================
Hits 7378 7378
Misses 7808 7808
🚀 New features to boost your workflow:
|
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Before:
persistent_cache_task_idgenerated as 10 bytes using CRC32Now:
persistent_cache_task_idgenerated as 64 bytes using SHA256.Reason: 10 bytes cannot pass through RocksDB's 64-bit prefix index.
Related Issue
Motivation and Context
Screenshots (if appropriate)