feat: add proxy port to host when announce #1292
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: chlins <chlins.zhang@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1292 +/- ##
=======================================
Coverage 48.73% 48.73%
=======================================
Files 60 60
Lines 15068 15068
=======================================
Hits 7344 7344
Misses 7724 7724
🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates how the
SchedulerAnnouncerconstructs theAnnounceHostRequest, ensuring that configuration values are correctly propagated to the request. The most important changes are related to improved usage of configuration parameters.Configuration propagation improvements:
scheduler_cluster_idfield inAnnounceHostRequestnow uses the value fromself.config.host.scheduler_cluster_id, defaulting to zero if not set, instead of a hardcoded zero.proxy_portfield is set inAnnounceHostRequest, using the value fromself.config.proxy.server.portcast to ani32.Description
Related Issue
Motivation and Context
Screenshots (if appropriate)