feat: add X-Dragonfly-Server-IP for response proxy ip #1295
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gaius <gaius.qi@gmail.com>
BruceAko
approved these changes
Aug 20, 2025
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1295 +/- ##
==========================================
- Coverage 48.74% 48.72% -0.02%
==========================================
Files 60 60
Lines 15072 15078 +6
==========================================
Hits 7347 7347
- Misses 7725 7731 +6
🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request adds support for including the server's IP address in the response headers for requests handled by the Dragonfly proxy. The main focus is to provide clients with information about which server processed their request by introducing a new response header and updating the relevant code paths to populate it.
Header support improvements:
DRAGONFLY_SERVER_IP_HEADERinheader.rsto represent the response header key for the server's IP address.make_response_headersfunction inmod.rsto accept aserver_ipparameter and insert the server IP into the response headers using the new header key. [1] [2]make_response_headersinproxy_via_dfdaemonto pass the server's IP address from the configuration.Related Issue
Motivation and Context
Screenshots (if appropriate)