Skip to content

Conversation

gaius-qi
Copy link
Member

@gaius-qi gaius-qi commented Aug 5, 2025

Description

This pull request updates the HTTP client configuration in the dragonfly-client-backend/src/http.rs file to disable support for several content-encoding compression algorithms. The main change is switching from enabling compression formats to explicitly disabling them in the client builder.

HTTP client compression configuration:

  • Changed the reqwest::Client::builder() calls to use .no_gzip(), .no_brotli(), .no_zstd(), and .no_deflate() instead of enabling these compression algorithms, effectively disabling support for gzip, brotli, zstd, and deflate encodings. [1] [2]

Related Issue

Motivation and Context

Screenshots (if appropriate)

@gaius-qi gaius-qi added this to the v2.4.0 milestone Aug 5, 2025
@gaius-qi gaius-qi self-assigned this Aug 5, 2025
@gaius-qi gaius-qi added the enhancement New feature or request label Aug 5, 2025
chlins
chlins previously approved these changes Aug 5, 2025
Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chlins chlins enabled auto-merge (squash) August 5, 2025 08:50
Copy link

codecov bot commented Aug 5, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@f0c9830). Learn more about missing BASE report.
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1273   +/-   ##
=======================================
  Coverage        ?   48.47%           
=======================================
  Files           ?       60           
  Lines           ?    14998           
  Branches        ?        0           
=======================================
  Hits            ?     7270           
  Misses          ?     7728           
  Partials        ?        0           
Files with missing lines Coverage Δ
dragonfly-client-backend/src/http.rs 98.34% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: Gaius <gaius.qi@gmail.com>
Copy link
Contributor

@LunaWhispers LunaWhispers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chlins chlins merged commit 52b263a into main Aug 5, 2025
7 checks passed
@chlins chlins deleted the feature/brotli branch August 5, 2025 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants