Skip to content

Conversation

gaius-qi
Copy link
Member

@gaius-qi gaius-qi commented Aug 6, 2025

Description

This pull request adds support for the openssl crate in both dragonfly-client-util and dragonfly-client and enhances the Docker images by including the grpcurl tool. The main changes improve debugging and testing capabilities for gRPC services in CI environments and prepare the Rust projects for potential future use of OpenSSL.

Docker image enhancements:

  • Added installation of grpcurl in the pprof build stage of both ci/Dockerfile and ci/Dockerfile.debug, enabling gRPC endpoint testing and debugging. [1] [2]
  • Included grpcurl binary in the final Docker images by copying it from the pprof build stage. [1] [2]

Rust workspace dependency updates:

  • Added openssl as a workspace dependency in dragonfly-client-util/Cargo.toml and dragonfly-client/Cargo.toml, preparing both crates for cryptographic operations or secure communication. [1] [2]

Related Issue

Motivation and Context

Screenshots (if appropriate)

Signed-off-by: Gaius <gaius.qi@gmail.com>
@gaius-qi gaius-qi added this to the v2.4.0 milestone Aug 6, 2025
@gaius-qi gaius-qi self-assigned this Aug 6, 2025
@gaius-qi gaius-qi added the enhancement New feature or request label Aug 6, 2025
@LunaWhispers LunaWhispers enabled auto-merge (squash) August 6, 2025 08:17
Copy link
Contributor

@LunaWhispers LunaWhispers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link

codecov bot commented Aug 6, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 48.47%. Comparing base (e415df9) to head (b5885d2).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1276      +/-   ##
==========================================
+ Coverage   48.43%   48.47%   +0.04%     
==========================================
  Files          60       60              
  Lines       15011    15011              
==========================================
+ Hits         7270     7277       +7     
+ Misses       7741     7734       -7     

see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@LunaWhispers LunaWhispers merged commit e1ae65a into main Aug 6, 2025
9 checks passed
@LunaWhispers LunaWhispers deleted the feature/grpcurl branch August 6, 2025 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants