Skip to content

Conversation

gaius-qi
Copy link
Member

@gaius-qi gaius-qi commented Aug 6, 2025

Description

This pull request introduces improvements to tracing and debugging capabilities, updates dependency versions, and addresses a double-decompression issue in HTTP downloads. The most significant changes are grouped below:

Tracing and Debugging Enhancements

  • Added the console-subscriber dependency to dragonfly-client and enabled the console tracing layer when log level is set to TRACE, allowing for better visibility into spawned tasks during debugging. (dragonfly-client/Cargo.toml, dragonfly-client/src/tracing/mod.rs) [1] [2]
  • Updated tokio dependency to include the tracing feature, and added configuration to enable tokio_unstable for advanced runtime features. (Cargo.toml, .cargo/config.toml) [1] [2]
  • Updated Dockerfiles to install and include the tokio-console binary in both release and debug images, improving runtime introspection for deployed containers. (ci/Dockerfile, ci/Dockerfile.debug, ci/Dockerfile.dfinit) [1] [2] [3] [4] [5] [6] [7]

Dependency and Version Updates

  • Bumped the workspace and all internal package versions from 1.0.9 to 1.0.10 for consistency and release tracking. (Cargo.toml) [1] [2]

HTTP Download Reliability

  • Disabled automatic compression (gzip, brotli, zstd, deflate) in HTTP client code to prevent double-decompression errors when proxying downloads, ensuring uncompressed content is stored and served correctly. (dragonfly-client-backend/src/http.rs) [1] [2]

Related Issue

Motivation and Context

Screenshots (if appropriate)

….0.0.1:6669` when log level is TRACE

Signed-off-by: Gaius <gaius.qi@gmail.com>
@gaius-qi gaius-qi added this to the v2.4.0 milestone Aug 6, 2025
@gaius-qi gaius-qi self-assigned this Aug 6, 2025
@gaius-qi gaius-qi added the enhancement New feature or request label Aug 6, 2025
LunaWhispers
LunaWhispers previously approved these changes Aug 6, 2025
Copy link
Contributor

@LunaWhispers LunaWhispers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@LunaWhispers LunaWhispers enabled auto-merge (squash) August 6, 2025 06:38
chlins
chlins previously approved these changes Aug 6, 2025
Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gaius-qi gaius-qi dismissed stale reviews from chlins and LunaWhispers via b606bc4 August 6, 2025 06:44
Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@LunaWhispers LunaWhispers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link

codecov bot commented Aug 6, 2025

Codecov Report

❌ Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 48.47%. Comparing base (848737e) to head (b606bc4).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
dragonfly-client/src/tracing/mod.rs 0.00% 4 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1275      +/-   ##
==========================================
+ Coverage   48.44%   48.47%   +0.03%     
==========================================
  Files          60       60              
  Lines       15008    15011       +3     
==========================================
+ Hits         7270     7277       +7     
+ Misses       7738     7734       -4     
Files with missing lines Coverage Δ
dragonfly-client-backend/src/http.rs 98.34% <ø> (ø)
dragonfly-client/src/tracing/mod.rs 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@LunaWhispers LunaWhispers merged commit e415df9 into main Aug 6, 2025
7 checks passed
@LunaWhispers LunaWhispers deleted the feature/tokio-console branch August 6, 2025 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants