-
Notifications
You must be signed in to change notification settings - Fork 41
chore(deps): remove unused dependencies #1274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Signed-off-by: Gaius <gaius.qi@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1274 +/- ##
==========================================
+ Coverage 48.47% 48.51% +0.04%
==========================================
Files 60 60
Lines 14998 14998
==========================================
+ Hits 7270 7277 +7
+ Misses 7728 7721 -7 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Description
This pull request removes several unused or unnecessary dependencies from the
Cargo.toml
files across multipledragonfly-client
sub-crates, helping to streamline the codebase and reduce build complexity.Dependency cleanup:
validator
andhumantime
dependencies fromdragonfly-client/Cargo.toml
as they are no longer needed.openssl
andlru
dependencies fromdragonfly-client/Cargo.toml
to reduce external dependency footprint. [1] [2]fslock
fromdragonfly-client/Cargo.toml
, likely because file locking is handled elsewhere or is no longer required.hyper
,openssl
fromdragonfly-client-util/Cargo.toml
to avoid redundant or unused libraries. [1] [2]sha2
andlru
fromdragonfly-client-storage/Cargo.toml
andtoml
fromdragonfly-client-init/Cargo.toml
to further clean up unused dependencies. [1] [2]Related Issue
Motivation and Context
Screenshots (if appropriate)