Skip to content

Conversation

gaius-qi
Copy link
Member

@gaius-qi gaius-qi commented Aug 6, 2025

Description

This pull request removes several unused or unnecessary dependencies from the Cargo.toml files across multiple dragonfly-client sub-crates, helping to streamline the codebase and reduce build complexity.

Dependency cleanup:

  • Removed validator and humantime dependencies from dragonfly-client/Cargo.toml as they are no longer needed.
  • Removed openssl and lru dependencies from dragonfly-client/Cargo.toml to reduce external dependency footprint. [1] [2]
  • Removed fslock from dragonfly-client/Cargo.toml, likely because file locking is handled elsewhere or is no longer required.
  • Removed hyper, openssl from dragonfly-client-util/Cargo.toml to avoid redundant or unused libraries. [1] [2]
  • Removed sha2 and lru from dragonfly-client-storage/Cargo.toml and toml from dragonfly-client-init/Cargo.toml to further clean up unused dependencies. [1] [2]

Related Issue

Motivation and Context

Screenshots (if appropriate)

@gaius-qi gaius-qi added this to the v2.4.0 milestone Aug 6, 2025
@gaius-qi gaius-qi self-assigned this Aug 6, 2025
@gaius-qi gaius-qi added the enhancement New feature or request label Aug 6, 2025
chlins
chlins previously approved these changes Aug 6, 2025
Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chlins chlins enabled auto-merge (squash) August 6, 2025 03:02
LunaWhispers
LunaWhispers previously approved these changes Aug 6, 2025
Copy link
Contributor

@LunaWhispers LunaWhispers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Signed-off-by: Gaius <gaius.qi@gmail.com>
@gaius-qi gaius-qi dismissed stale reviews from LunaWhispers and chlins via 9ad0f5f August 6, 2025 03:06
Copy link

codecov bot commented Aug 6, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 48.51%. Comparing base (b2ac70f) to head (9ad0f5f).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1274      +/-   ##
==========================================
+ Coverage   48.47%   48.51%   +0.04%     
==========================================
  Files          60       60              
  Lines       14998    14998              
==========================================
+ Hits         7270     7277       +7     
+ Misses       7728     7721       -7     

see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@LunaWhispers LunaWhispers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@fcgxz2003 fcgxz2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chlins chlins merged commit 7796ee7 into main Aug 6, 2025
7 checks passed
@chlins chlins deleted the feature/dep branch August 6, 2025 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants