refactor: remove the seed peer announcement to manager #1261
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: chlins <chlins.zhang@gmail.com>
55017c7 to
7ef781a
Compare
gaius-qi
requested changes
Aug 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request simplifies the codebase by removing functionality related to seed peer cluster management and the
ManagerAnnouncercomponent. The changes streamline the configuration and announcement logic by focusing on the scheduler while eliminating unused fields, functions, and dependencies.Removal of seed peer cluster-related functionality:
cluster_idandkeepalive_intervalfields from theSeedPeerstruct indragonfly-client-config/src/dfdaemon.rs, along with their associated default values and validation logic. [1] [2] [3] [4] [5]Removal of
ManagerAnnouncer:ManagerAnnouncerstruct and its implementation, including methods for announcing seed peer information to the manager, indragonfly-client/src/announcer/mod.rs. This also removed the associated gRPC client and request types from the imports. [1] [2]Description
Related Issue
Motivation and Context
Screenshots (if appropriate)