feat: rename tracing field from uri to url in proxy handler functions
#1260
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ions Signed-off-by: Gaius <gaius.qi@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1260 +/- ##
==========================================
+ Coverage 47.80% 48.49% +0.69%
==========================================
Files 60 60
Lines 14805 14991 +186
==========================================
+ Hits 7077 7270 +193
+ Misses 7728 7721 -7
🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request updates the logging instrumentation in the
dragonfly-clientproxy module to use the term "url" instead of "uri" for consistency and clarity. The changes affect both thehandlerandupgraded_handlerfunctions.Updates to logging fields:
dragonfly-client/src/proxy/mod.rs: Updated the#[instrument]macro in bothhandlerandupgraded_handlerfunctions to replace theurifield withurl. [1] [2]dragonfly-client/src/proxy/mod.rs: Modified theSpan::current().recordcalls in bothhandlerandupgraded_handlerto record theurlfield instead ofuri. [1] [2]Related Issue
Motivation and Context
Screenshots (if appropriate)