feat:removes the load_to_cache field #1264
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
44896e6 to
c61239e
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1264 +/- ##
==========================================
- Coverage 48.51% 48.44% -0.08%
==========================================
Files 60 60
Lines 14998 15008 +10
==========================================
- Hits 7277 7270 -7
- Misses 7721 7738 +17
🚀 New features to boost your workflow:
|
This pull request removes the load_to_cache field and adds trait method definitions to dfdaemon_download.rs and dfdaemon_upload.rs. - Removed cache-related processing from Task handling. - Added trait method definitions such as download_cache_task to dfdaemon_download.rs and dfdaemon_upload.rs to comply with the API format of version 2.1.55. - Aim to allow Task to focus on disk interactions while delegating memory cache operations to CacheTask. Signed-off-by: fu220 <2863318196@qq.com>
c61239e to
1941328
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request removes the
load_to_cachefield and adds trait method definitions todfdaemon_download.rsanddfdaemon_upload.rs.Related Issue
Changes
download_cache_tasktodfdaemon_download.rsanddfdaemon_upload.rsto comply with the API format of version 2.1.55.Motivation and Context
Screenshots (if appropriate)