feat: Enhance stat_task error handling in dfdaemon_download and dfdaemon_upload #1251
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…k stat Signed-off-by: Gaius <gaius.qi@gmail.com>
…sponse Signed-off-by: Gaius <gaius.qi@gmail.com>
BruceAko
approved these changes
Jul 23, 2025
yxxhero
approved these changes
Jul 23, 2025
CormickKneey
approved these changes
Jul 23, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1251 +/- ##
==========================================
- Coverage 47.26% 47.23% -0.03%
==========================================
Files 60 60
Lines 14583 14591 +8
==========================================
Hits 6892 6892
- Misses 7691 7699 +8
🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request refactors error handling in the
statmethod for bothDfdaemonDownloadServerHandlerandDfdaemonUploadServerHandlerin thedragonfly-clientproject. The changes improve error logging and map specific errors to more appropriate gRPC statuses.Error handling improvements:
Updated the
statmethod inDfdaemonDownloadServerHandlerto use amatchblock for handling the result of thetask.statcall. Added detailed error logging withtask_idcontext and mappedClientError::TaskNotFoundto aStatus::not_foundgRPC status, while other errors are mapped toStatus::internal. (dragonfly-client/src/grpc/dfdaemon_download.rs, dragonfly-client/src/grpc/dfdaemon_download.rsL707-R728)Applied the same refactoring to the
statmethod inDfdaemonUploadServerHandler, ensuring consistent error handling, detailed logging, and specific gRPC status mapping forClientError::TaskNotFound. (dragonfly-client/src/grpc/dfdaemon_upload.rs, dragonfly-client/src/grpc/dfdaemon_upload.rsL672-R693)Related Issue
Motivation and Context
Screenshots (if appropriate)