feat: Bump dragonfly-api to 2.1.49 and add local_only support for task stat #1250
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…k stat Signed-off-by: Gaius <gaius.qi@gmail.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1250 +/- ##
==========================================
- Coverage 47.42% 47.26% -0.16%
==========================================
Files 60 60
Lines 14536 14583 +47
==========================================
- Hits 6893 6892 -1
- Misses 7643 7691 +48
🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request introduces several updates to the Dragonfly client, focusing on enhancing task handling, improving tracing, and standardizing headers. Key changes include adding a
local_onlyflag to task status queries, extending task metadata handling for local storage, and renaming constants for clarity. Below is a breakdown of the most important changes:Enhancements to Task Handling:
local_onlyflag to thestat_taskmethods in bothDfdaemonDownloadServerHandlerandDfdaemonUploadServerHandler, allowing task status to be queried exclusively from local storage. This includes updates to span recording and method signatures. (dragonfly-client/src/grpc/dfdaemon_download.rs: [1] [2] [3];dragonfly-client/src/grpc/dfdaemon_upload.rs: [4] [5] [6]statmethod in theTaskstruct to support retrieving task metadata and pieces from local storage whenlocal_onlyis true. This includes filtering unfinished pieces and constructing a detailedCommonTaskresponse. (dragonfly-client/src/resource/task.rs: dragonfly-client/src/resource/task.rsL1838-R1908)Improvements to Tracing and Metrics:
local_onlyflag in both download and upload server handlers for better observability. (dragonfly-client/src/grpc/dfdaemon_download.rs: [1] [2];dragonfly-client/src/grpc/dfdaemon_upload.rs: [3] [4]Header Standardization:
_HEADERto their names (e.g.,DRAGONFLY_PIECE_LENGTHtoDRAGONFLY_PIECE_LENGTH_HEADER). Updated all references accordingly, including tests and utility functions. (dragonfly-client/src/proxy/header.rs: [1] [2] [3] [4]DRAGONFLY_TASK_DOWNLOAD_FINISHED_HEADER, to indicate when a task download is complete. Added logic to include this header in responses. (dragonfly-client/src/proxy/header.rs: [1];dragonfly-client/src/proxy/mod.rs: [2]Codebase Enhancements:
get_allmethod to thePiecestruct for retrieving all pieces of a task from local storage. (dragonfly-client/src/resource/piece.rs: dragonfly-client/src/resource/piece.rsR147-R151)HashMap) and minor refactoring in theTaskstruct to support new functionality. (dragonfly-client/src/resource/task.rs: [1] [2] [3]Dependency Update:
dragonfly-apidependency version from2.1.47to2.1.49inCargo.toml. (Cargo.toml: Cargo.tomlL32-R32)Related Issue
Motivation and Context
Screenshots (if appropriate)