-
Notifications
You must be signed in to change notification settings - Fork 41
refactor: improve filter_entries test function #1259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: LunaWhispers <yangmuyucs@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1259 +/- ##
==========================================
+ Coverage 47.80% 48.49% +0.69%
==========================================
Files 60 60
Lines 14805 14991 +186
==========================================
+ Hits 7077 7270 +193
+ Misses 7728 7721 -7
🚀 New features to boost your workflow:
|
Signed-off-by: LunaWhispers <yangmuyucs@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merge the test funcs of 4 filters into one func by test cases.
Signed-off-by: LunaWhispers <yangmuyucs@gmail.com>
Signed-off-by: LunaWhispers <yangmuyucs@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Description
improve filter_entries test function, merge filter_entries test case.
Related Issue
Motivation and Context
Screenshots (if appropriate)