Skip to content

Conversation

LunaWhispers
Copy link
Contributor

Description

improve filter_entries test function, merge filter_entries test case.

Related Issue

Motivation and Context

Screenshots (if appropriate)

Signed-off-by: LunaWhispers <yangmuyucs@gmail.com>
@LunaWhispers LunaWhispers requested review from gaius-qi and chlins July 28, 2025 11:32
@LunaWhispers LunaWhispers requested a review from a team as a code owner July 28, 2025 11:32
@LunaWhispers LunaWhispers requested a review from BraveY July 28, 2025 11:32
@github-actions github-actions bot requested a review from xujihui1985 July 28, 2025 11:32
@LunaWhispers LunaWhispers added the enhancement New feature or request label Jul 28, 2025
Copy link

codecov bot commented Jul 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 48.49%. Comparing base (b30993e) to head (97b1ae1).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1259      +/-   ##
==========================================
+ Coverage   47.80%   48.49%   +0.69%     
==========================================
  Files          60       60              
  Lines       14805    14991     +186     
==========================================
+ Hits         7077     7270     +193     
+ Misses       7728     7721       -7     
Files with missing lines Coverage Δ
dragonfly-client/src/bin/dfget/main.rs 47.99% <100.00%> (+9.55%) ⬆️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: LunaWhispers <yangmuyucs@gmail.com>
Copy link
Member

@gaius-qi gaius-qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge the test funcs of 4 filters into one func by test cases.

Signed-off-by: LunaWhispers <yangmuyucs@gmail.com>
Signed-off-by: LunaWhispers <yangmuyucs@gmail.com>
Copy link
Member

@gaius-qi gaius-qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chlins chlins merged commit 1aefde8 into dragonflyoss:main Jul 29, 2025
7 checks passed
@LunaWhispers LunaWhispers deleted the test/filter branch August 28, 2025 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants