feat: use piece_timeout for list task entries #1255
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gaius <gaius.qi@gmail.com>
BruceAko
approved these changes
Jul 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request simplifies the timeout handling logic in the
DfdaemonDownloadimplementation by removing the custom timeout parsing logic and defaulting to the configuredpiece_timeoutvalue.Simplification of timeout handling:
timeoutfrom the request, including error handling and metrics collection for invalid timeouts. The implementation now directly uses thepiece_timeoutvalue from the configuration (self.config.download.piece_timeout). (dragonfly-client/src/grpc/dfdaemon_download.rs, dragonfly-client/src/grpc/dfdaemon_download.rsL770-L780)timeoutfield in thebackend.headcall to always use the configuredpiece_timeout, ensuring consistent timeout behavior. (dragonfly-client/src/grpc/dfdaemon_download.rs, dragonfly-client/src/grpc/dfdaemon_download.rsL792-R781)Related Issue
Motivation and Context
Screenshots (if appropriate)