feat: use piece_timeout for list task entries #1254
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gaius <gaius.qi@gmail.com>
BruceAko
approved these changes
Jul 24, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1254 +/- ##
==========================================
+ Coverage 47.28% 47.31% +0.02%
==========================================
Files 60 60
Lines 14591 14582 -9
==========================================
Hits 6899 6899
+ Misses 7692 7683 -9
🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request simplifies the timeout handling logic in the
DfdaemonDownloadServerHandlerimplementation by removing the conditional timeout parsing and directly using the default configuration value.Simplification of timeout handling:
requestobject. The implementation now directly usesself.config.download.piece_timeoutas the timeout value. (dragonfly-client/src/grpc/dfdaemon_download.rs, dragonfly-client/src/grpc/dfdaemon_download.rsL770-L780)timeoutfield in the backend request to always useself.config.download.piece_timeout, ensuring consistency in timeout configuration. (dragonfly-client/src/grpc/dfdaemon_download.rs, dragonfly-client/src/grpc/dfdaemon_download.rsL792-R781)Related Issue
Motivation and Context
Screenshots (if appropriate)