Skip to content

feat: add include-files argrument in the downloaded directory #1247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jul 25, 2025
Merged

feat: add include-files argrument in the downloaded directory #1247

merged 8 commits into from
Jul 25, 2025

Conversation

LunaWhispers
Copy link
Contributor

@LunaWhispers LunaWhispers commented Jul 22, 2025 •
edited
Loading

Description

Include files in the downloaded directory, use relative path. e.g. --include-files='.txt' --include-files='.txt'

  • Include files in the downloaded directory, use relative path.
  • Support regular expression matching, e.g. 'dir/', '.txt'.
  • Support illegal path checking

Related Issue

Motivation and Context

Screenshots (if appropriate)

@LunaWhispers
add include-files arg
f735b28 
Signed-off-by: LunaWhispers <yangmuyucs@gmail.com>
@LunaWhispers
fix regular expression matching
0c3b2cf 
Signed-off-by: LunaWhispers <yangmuyucs@gmail.com>
@LunaWhispers LunaWhispers requested review from gaius-qi and chlins July 22, 2025 04:17
@LunaWhispers LunaWhispers requested a review from a team as a code owner July 22, 2025 04:17
@LunaWhispers LunaWhispers added the enhancement New feature or request label Jul 22, 2025
@LunaWhispers LunaWhispers requested a review from BraveY July 22, 2025 04:17
@github-actions github-actions bot requested a review from CormickKneey July 22, 2025 04:17
@LunaWhispers
fix lint
d3eafad 
Signed-off-by: LunaWhispers <yangmuyucs@gmail.com>
@codecov Codecov
Copy link

codecov bot commented Jul 22, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 87.05357% with 29 lines in your changes missing coverage. Please review.

Project coverage is 47.90%. Comparing base (aedbc2c) to head (8cb78b3).
Report is 17 commits behind head on main.

Files with missing lines Patch % Lines
dragonfly-client/src/bin/dfget/main.rs 87.05% 29 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1247      +/-   ##
==========================================
+ Coverage   47.62%   47.90%   +0.27%     
==========================================
  Files          60       60              
  Lines       14471    14809     +338     
==========================================
+ Hits         6892     7094     +202     
- Misses       7579     7715     +136
Files with missing lines Coverage Δ
dragonfly-client-backend/src/lib.rs 95.47% <ø> (ø)
dragonfly-client/src/bin/dfget/main.rs 39.27% <87.05%> (+13.54%) ⬆️

... and 11 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@LunaWhispers LunaWhispers enabled auto-merge (squash) July 22, 2025 06:23
gaius-qi
gaius-qi requested changes Jul 22, 2025
View reviewed changes
@LunaWhispers
add glob to check path
af5e202 
Signed-off-by: LunaWhispers <yangmuyucs@gmail.com>
@LunaWhispers
change include-files help
1e2c4e0 
Signed-off-by: LunaWhispers <yangmuyucs@gmail.com>
chlins
chlins reviewed Jul 24, 2025
View reviewed changes
@LunaWhispers
move validate include-files args
05680aa 
Signed-off-by: LunaWhispers <yangmuyucs@gmail.com>
@LunaWhispers
remove should_validate_include_files test
a22dc92 
Signed-off-by: LunaWhispers <yangmuyucs@gmail.com>
gaius-qi
gaius-qi requested changes Jul 24, 2025
View reviewed changes
@LunaWhispers
add return error, fix parent dir
8cb78b3 
Signed-off-by: LunaWhispers <yangmuyucs@gmail.com>
gaius-qi
gaius-qi approved these changes Jul 25, 2025
View reviewed changes
Copy link
Member

@gaius-qi gaius-qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

chlins
chlins approved these changes Jul 25, 2025
View reviewed changes
Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@LunaWhispers LunaWhispers merged commit cca88b3 into dragonflyoss:main Jul 25, 2025
7 checks passed
@LunaWhispers LunaWhispers deleted the feature/include-files branch August 28, 2025 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaius-qi gaius-qi gaius-qi approved these changes

@chlins chlins chlins approved these changes

@BraveY BraveY Awaiting requested review from BraveY BraveY was automatically assigned from dragonflyoss/dragonfly-approvers

@CormickKneey CormickKneey Awaiting requested review from CormickKneey

Assignees

@LunaWhispers LunaWhispers

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LunaWhispers @gaius-qi @chlins