feat: add proxy port to host in v1 #535
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: chlins <chlins.zhang@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the API to add support for specifying a proxy server port in the
Hostmessage, along with validation to ensure the port is within the allowed range. It also bumps the package version to reflect the new feature.API changes:
proxy_portof typeint32to theHostmessage incommon.proto, with validation to require the value to be in the range [1024, 65535).common.pb.goto include the newProxyPortfield and accessor method, and adjusted the protobuf descriptors accordingly. [1] [2] [3] [4]Validation logic:
common.pb.validate.goto ensure thatProxyPortis within the allowed range, returning an error if not.Versioning:
Cargo.tomlfrom2.1.58to2.1.59.Description
Related Issue
Motivation and Context