fix: handling of indent inside embedded language #718
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mb21
reviewed
Jun 5, 2025
Co-authored-by: Mauro Bieg <mb21@users.noreply.github.com>
mb21
reviewed
Jun 5, 2025
Co-authored-by: Mauro Bieg <mb21@users.noreply.github.com>
dsherret
reviewed
Jun 12, 2025
dsherret
reviewed
Jun 12, 2025
kt3k
added a commit
to denoland/deno
that referenced
this pull request
Jun 17, 2025
This commit fixes the handling of indent inside the template languages. See dprint/dprint-plugin-typescript#718 for details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the handling of indent inside the template literals with embedded languages.
Currently the leading whitespaces in the line of embedded external languages are handled as part of source code, and that causes the issue denoland/deno#29164 . This PR fixes it by skipping the leading whitespaces, but instead adding
StartIndentandFinishIndentIR signals based on current indent level of the embedded language.related denoland/deno#29164