Skip to content

Ensure changes to repo level source-build files are code reviewed by source-build experts #3435

@MichaelSimons

Description

@MichaelSimons

Here is an example change that should have been reviewed by a source-build expert. The changes to the SourceBuildPrebuiltBaseline.xml caused prebuilts to be added and weren't caught until internal source-build CI.

Suggestions:

  1. Add comments to the repo level source-build files to promote having a source-build expert code review any changes
  2. If a repo has a CODEOWNERS file, assign ownership of the repo level source-build files to the source-build team to ensure they get included in code reviews.

Repos with comments only:

Repos with both the comments and CODEOWNERS entry:

Metadata

Metadata

Labels

No labels
No labels

Type

No type

Projects

Status

Done

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions