-
Notifications
You must be signed in to change notification settings - Fork 138
Closed
Description
Here is an example change that should have been reviewed by a source-build expert. The changes to the SourceBuildPrebuiltBaseline.xml caused prebuilts to be added and weren't caught until internal source-build CI.
Suggestions:
- Add comments to the repo level source-build files to promote having a source-build expert code review any changes
- If a repo has a CODEOWNERS file, assign ownership of the repo level source-build files to the source-build team to ensure they get included in code reviews.
Repos with comments only:
- sourcelink: add review comment to sb files sourcelink#1038
- arcade: add review comment to sb files arcade#13740
- command-line-api: add review comment to sb files command-line-api#2204
- emsdk: add review comment to sb files emsdk#353
- xliff-tasks: add review comment to sb files xliff-tasks#793
- cecil: add review comment to sb files cecil#88
- runtime: add review comment to sb files runtime#87003
- symreader: add review comment to sb files symreader#290
- xdt: add review comment to sb files xdt#516
- msbuild: add review comment to sb files msbuild#8824
- aspnetcore: add review comment to sb files aspnetcore#48566
- deployment-tools: add review comment to sb files deployment-tools#279
- templating: add review comment to sb files templating#6660
- nuget-client: add review comment to sb files NuGet/NuGet.Client#5196
- test-templates: add review comment to sb files test-templates#305
- sdk: add review comment to sb files sdk#32966
Repos with both the comments and CODEOWNERS
entry:
- source-build-reference-packages: add review comment to sb files source-build-reference-packages#690
- source-build-externals: add review comment to sb files source-build-externals#153
- diagnostics: add review comment to sb files diagnostics#3934
- razor: add review comment to sb files razor#8787
- roslyn: add review comment to sb files roslyn#68409
- roslyn-analyzers: add review comment to sb files roslyn-analyzers#6666
- format: add review comment to sb files format#1869
- fsharp: add review comment to sb files fsharp#15288
- vstest: Update source-build prebuilt baseline microsoft/vstest#4503
- instaler: Enable source-build pvp flow for installer installer#16550
omajid, Evangelink and MichaelSimons
Metadata
Metadata
Assignees
Labels
No labels
Type
Projects
Status
Done