Skip to content

Extra tests for type hints #14552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 9, 2023
Merged

Extra tests for type hints #14552

merged 1 commit into from
Jan 9, 2023

Conversation

psfinaki
Copy link
Member

@psfinaki psfinaki commented Jan 6, 2023

closes #14378

This appears to be already working so just adding a test.

Note we'll have signature (lambda?) hints for this at some point (and they will probably be above the line).

image

@psfinaki psfinaki requested a review from a team as a code owner January 6, 2023 12:49
@vzarytovskii vzarytovskii enabled auto-merge (squash) January 6, 2023 12:58
@psfinaki psfinaki disabled auto-merge January 6, 2023 14:33
@psfinaki psfinaki enabled auto-merge (squash) January 6, 2023 14:33
@psfinaki psfinaki merged commit 24291f2 into dotnet:main Jan 9, 2023
@allisonchou allisonchou mentioned this pull request Jan 16, 2023
Closed
@psfinaki psfinaki deleted the psfinaki/hints-9 branch February 10, 2025 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vzarytovskii vzarytovskii vzarytovskii approved these changes

+1 more reviewer

@0101 0101 0101 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
release/17.6
Projects
F# Compiler and Tooling
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrong type hint for a module value containing a lambda
3 participants
@psfinaki @0101 @vzarytovskii