Rename FSharpReferencedProject.ProjectFileName for clarity #12431
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging @Krzysztof-Cieslak for review (since he found this mismatch in the first place). |
|
👍 for the change, the naming caused regression in Ionide ( |
Krzysztof-Cieslak
approved these changes
Nov 19, 2021
This renames the `projectFileName` field and `FileName` property to reflect the actual use: the project's output file. This was unclear based on docs, but clear based on usage, and so docs were added to help ensure correct usage.
2d2af04 to
97c51d0
Compare
KevinRansom
approved these changes
Nov 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This renames the
projectFileNamefield andFileNameproperty to reflect theactual use: the project's output file. This was unclear based on docs, but clear based on usage,
and so docs were added to help ensure correct usage.