Skip to content

Move SB metadata to intermediates #2090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 2, 2024
Merged

Move SB metadata to intermediates #2090

merged 2 commits into from
Feb 2, 2024

Conversation

ellahathaway
Copy link
Member

The changes in this pull request aim to improve the UX and guideance around the SourceBuild metadata by placing the metadata on explicit source-build intermediates.

The changes include:

  • Removing existing SourceBuild metadata from all non-intermediate dependencies.
  • Defining new explicit intermediate dependencies and adding SourceBuild metadata to those dependencies.

Related to dotnet/source-build#3373 and dotnet/source-build#4073

@ellahathaway ellahathaway requested a review from a team February 1, 2024 23:30
@ellahathaway ellahathaway mentioned this pull request Feb 1, 2024
Closed
@ellahathaway ellahathaway enabled auto-merge (squash) February 2, 2024 16:56
@ellahathaway ellahathaway merged commit d102001 into dotnet:main Feb 2, 2024
@ghost ghost added this to the Next milestone Feb 2, 2024
@ellahathaway ellahathaway deleted the sb-metadata branch February 2, 2024 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mthalman mthalman mthalman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Next
Development

Successfully merging this pull request may close these issues.
2 participants
@ellahathaway @mthalman