Skip to content

Allow overriding upgrade code seed and dependency key #8195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 18, 2021
Merged

Allow overriding upgrade code seed and dependency key #8195

merged 1 commit into from
Nov 18, 2021

Conversation

NikolaMilosavljevic
Copy link
Member

This allows optional override of UpgradeCode seed and DependencyKey value in MSI-producing projects, in any consumer repo, i.e. dotnet/runtime.

Essentially a forward port of 6.0 changes: #8174 and #8181

@NikolaMilosavljevic
Copy link
Member Author

@joeloff , @ericstj any concerns with this work for 7.0?

ericstj
ericstj approved these changes Nov 18, 2021
View reviewed changes
Copy link
Member

@ericstj ericstj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NikolaMilosavljevic NikolaMilosavljevic merged commit 7097001 into dotnet:main Nov 18, 2021
@danmoseley danmoseley mentioned this pull request Feb 7, 2022
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericstj ericstj ericstj approved these changes

@joeloff joeloff Awaiting requested review from joeloff

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NikolaMilosavljevic @ericstj