Add support for creating alternate aka.ms links #8194
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We want to be able to not only specify -Channel 7.0.1xx to install the sdk from daily links, but also -Channel 7.0. In order to do this, we need to be able to create multiple aka.ms links for repos that publish to the SDK channels. This change adds the "AlternateAkaMSChannelName" property to TargetChannelConfig and "AlternateShortUrlPrefix" to TargetFeedConfig. We then use this alternate prefix, when it exists, to create an additional aka.ms link in the LatestLinksManager.
alexperovich
approved these changes
Nov 16, 2021
epananth
approved these changes
Nov 16, 2021
mmitche
reviewed
Nov 18, 2021
src/Microsoft.DotNet.Build.Tasks.Feed/src/PublishArtifactsInManifestV2.cs
Outdated
Show resolved
Hide resolved
mmitche
reviewed
Nov 18, 2021
src/Microsoft.DotNet.Build.Tasks.Feed/src/PublishArtifactsInManifestV3.cs
Outdated
Show resolved
Hide resolved
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To double check:
For repos that publish to the SDK band channels, we occasionally want to create aka.ms links using both the sdk band version and the release channel version (i.e. 7.0.1xx and 7.0). This change introduces the concept of an alternate channel name and alternate short url prefix that will allow us to create aka.ms links for both on specified channels. As new sdk channels are added, which channel creates the release channel aka.ms links will need to manually rolled forward.
Tested here, having temporarily added an alternate channel name for the general testing channel (gentest): https://dev.azure.com/dnceng/internal/_build/results?buildId=1472816&view=logs&j=ba23343f-f710-5af9-782d-5bd26b102304&t=6e277ba4-1c1e-552d-b96f-db0aeb4be20a