[release/9.4] aspire config set writes appHostPath to ~/.aspire/settings.json globally, causing incorrect path resolution #10703
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: mitchdenny <513398+mitchdenny@users.noreply.github.com>
|
Should we even be writing the |
|
9.4.1 |
|
@mitchdenny we should take this PR for 9.4.1 for sure, once youre in this state it always happens.. We have more time now so is this the fix we want? |
|
Yes this is the right fix. |
We didn't write it to the global file. We wrote it to a local file that just happened to occupy the same space as the global file ;) |
mitchdenny
approved these changes
Jul 29, 2025
|
I put this in 9.4.1 @joperezr |
joperezr
approved these changes
Aug 1, 2025
WeihanLi
pushed a commit
to WeihanLi/aspire
that referenced
this pull request
Aug 13, 2025
…ngs.json globally, causing incorrect path resolution (dotnet#10703) * Initial plan * Rename global settings file from settings.json to globalsettings.json Co-authored-by: mitchdenny <513398+mitchdenny@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: mitchdenny <513398+mitchdenny@users.noreply.github.com>
This was referenced Aug 13, 2025
This was referenced Aug 27, 2025
Merged
Bump Aspire.Npgsql.EntityFrameworkCore.PostgreSQL from 9.4.0 to 9.4.1
L-U-M-E-N/Lumen.Modules.GRDF#2
Open
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #10700 to release/9.4
/cc @mitchdenny @copilot
Customer Impact
We found a bug related to using the
aspire runandaspire configcommands when there is a global aspire configuration file in$HOME/.aspire/settings.json. Basically because the local config is.aspire/settings.jsonand we search up the directory tree, it will find the global config and put settings in that.To solve this problem we renamed the global configuration file to
.aspire/globalsettings.jsonto avoid this conflict.Testing
Automated tests already used this approach for test isolation. Also did manual testing.
Risk
Low.
Regression?